Skip to content

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 23, 2026

Following #183, I think we can declare this project as typed, so dependents can stop relying on the third-party wcwidth-stubs?

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 23, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing hugovk:py.typed (2e17571) with master (4738d79)

Summary

✅ 38 untouched benchmarks

@jquast
Copy link
Owner

jquast commented Jan 23, 2026

Yes, I think so... does this mean I have to release another version to pypi for this to work?

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4738d79) to head (2e17571).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          604       604           
  Branches       145       145           
=========================================
  Hits           604       604           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugovk
Copy link
Contributor Author

hugovk commented Jan 23, 2026

Yes, but it's not urgent.

@jquast jquast merged commit 68a3bd5 into jquast:master Jan 23, 2026
43 checks passed
@hugovk hugovk deleted the py.typed branch January 23, 2026 22:28
@trim21
Copy link
Contributor

trim21 commented Jan 24, 2026

finally

@trim21
Copy link
Contributor

trim21 commented Jan 24, 2026

I'm going to add partial to wcwidth-stubs/py.typed and remove all pyi to make wcwidth-stubs a nope stubs.

jquast added a commit to jquast/pyte that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants